Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

[3.1.1 backport] Panic inside Mutable1xBody for nil shallow copy

Description

We don't have sufficient handling for a nil doc body retruned by shallow copy inside the function Mutable1xBody.

When we take a shallow copy of the document here https://github.com/couchbase/sync_gateway/blob/fe16b931b3923052ae6a8d4e6b400300ec86b6ab/db/revision_cache_interface.go#L160

If we get a nil body returned here we can get a panic here https://github.com/couchbase/sync_gateway/blob/fe16b931b3923052ae6a8d4e6b400300ec86b6ab/db/revision_cache_interface.go#L165 by trying to assign to a nil map. We should have a check to see if b in this code is nil and if so we should initialise an empty body so we can assign the rev and doc id without panicing.

Activity

CB robot April 8, 2024 at 10:12 PM

Build sync_gateway-3.2.0-350 contains sync_gateway commit 0e9999b with commit message:
: [3.1.1] Fix panic for assigning to nil map inside Mutable1xBody (#6275)

CB robot April 8, 2024 at 9:31 PM

Build sync_gateway-3.2.0-348 contains sync_gateway commit 0e9999b with commit message:
: [3.1.1] Fix panic for assigning to nil map inside Mutable1xBody (#6275)

CB robot April 8, 2024 at 8:53 PM

Build sync_gateway-3.2.0-346 contains sync_gateway commit 0e9999b with commit message:
: [3.1.1] Fix panic for assigning to nil map inside Mutable1xBody (#6275)

CB robot April 8, 2024 at 8:21 PM

Build sync_gateway-3.2.0-344 contains sync_gateway commit 0e9999b with commit message:
: [3.1.1] Fix panic for assigning to nil map inside Mutable1xBody (#6275)

CB robot April 8, 2024 at 7:41 PM

Build sync_gateway-3.2.0-342 contains sync_gateway commit 0e9999b with commit message:
: [3.1.1] Fix panic for assigning to nil map inside Mutable1xBody (#6275)

Fixed
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Story Points

Components

Sprint

Fix versions

Priority

Instabug

Open Instabug

PagerDuty

Sentry

Zendesk Support

Created May 25, 2023 at 10:19 PM
Updated August 31, 2024 at 10:57 AM
Resolved May 31, 2023 at 10:12 AM
Instabug